Skip to content

Commit b753f76

Browse files
committed
Fix failing async tests in Node 10
Dunno why they happened to work in Node 8 but whatever. Tested on both.
1 parent d37f595 commit b753f76

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

packages/react-dom/src/__tests__/ReactServerRenderingHydration-test.js

+5-9
Original file line numberDiff line numberDiff line change
@@ -444,20 +444,16 @@ describe('ReactDOMServerHydration', () => {
444444
});
445445

446446
it('should be able to use lazy components after hydrating', async () => {
447-
async function fakeImport(result) {
448-
return {default: result};
449-
}
450-
451447
const Lazy = React.lazy(
452448
() =>
453449
new Promise(resolve => {
454450
setTimeout(
455451
() =>
456-
resolve(
457-
fakeImport(function World() {
452+
resolve({
453+
default: function World() {
458454
return 'world';
459-
}),
460-
),
455+
},
456+
}),
461457
1000,
462458
);
463459
}),
@@ -491,7 +487,7 @@ describe('ReactDOMServerHydration', () => {
491487
expect(element.textContent).toBe('Hello loading');
492488

493489
jest.runAllTimers();
494-
await Lazy;
490+
await Promise.resolve();
495491
expect(element.textContent).toBe('Hello world');
496492
});
497493
});

packages/react-reconciler/src/__tests__/ReactIncrementalPerf-test.internal.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ describe('ReactDebugFiberPerf', () => {
573573
return <span />;
574574
}
575575

576-
async function fakeImport(result) {
576+
function fakeImport(result) {
577577
return {default: result};
578578
}
579579

@@ -600,7 +600,8 @@ describe('ReactDebugFiberPerf', () => {
600600
return <div />;
601601
}),
602602
);
603-
await LazyFoo;
603+
604+
await Promise.resolve();
604605

605606
ReactNoop.render(
606607
<Parent>

packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ describe('ReactLazy', () => {
319319
return fakeImport(Foo);
320320
});
321321

322-
const LazyForwardRef = lazy(async () => {
322+
const LazyForwardRef = lazy(() => {
323323
class Bar extends React.Component {
324324
render() {
325325
return <Text text="Bar" />;

0 commit comments

Comments
 (0)