You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feature[REMOVED][devtools]: turn off / hide location based component filters (#28417)
Following #28265, this should
disable location-based component filters.
```
// Following __debugSource removal from Fiber, the new approach for finding the source location
// of a component, represented by the Fiber, is based on lazily generating and parsing component stack frames
// To find the original location, React DevTools will perform symbolication, source maps are required for that.
// In order to start filtering Fibers, we need to find location for all of them, which can't be done lazily.
// Eager symbolication can become quite expensive for large applications.
```
I am planning to publish a patch version of RDT soon, so I think its
better to remove this feature, instead of shipping it in a broken state.
The reason for filtering out these filters is a potential cases, where
we load filters from the backend (like in RN, where we storing some
settings on device), or these filters can be stored in user land
(`window.__REACT_DEVTOOLS_COMPONENT_FILTERS__`).
Explicitly tested the case when:
1. Load current RDT extension, add location-based component filter
2. Reload the page and observe that previously created component filter
is preserved
3. Re-load RDT extension with these changes, observe there is no
previously created component filter and user can't create a new
location-based filter
4. Reload RDT extension without these changes, no location-based filters
saved, user can create location-based filters
DiffTrain build for commit d4cac3f.
Copy file name to clipboardexpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1
Original file line number
Diff line number
Diff line change
@@ -25707,7 +25707,7 @@ if (__DEV__) {
25707
25707
return root;
25708
25708
}
25709
25709
25710
-
var ReactVersion = "18.3.0-canary-47beb96cc-20240222";
25710
+
var ReactVersion = "18.3.0-canary-d4cac3f96-20240222";
Copy file name to clipboardexpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2
Original file line number
Diff line number
Diff line change
@@ -9171,7 +9171,7 @@ var devToolsConfig$jscomp$inline_1014 = {
9171
9171
throwError("TestRenderer does not support findFiberByHostInstance()");
9172
9172
},
9173
9173
bundleType: 0,
9174
-
version: "18.3.0-canary-47beb96cc-20240222",
9174
+
version: "18.3.0-canary-d4cac3f96-20240222",
9175
9175
rendererPackageName: "react-test-renderer"
9176
9176
};
9177
9177
varinternals$jscomp$inline_1195={
@@ -9202,7 +9202,7 @@ var internals$jscomp$inline_1195 = {
Copy file name to clipboardexpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2
Original file line number
Diff line number
Diff line change
@@ -9599,7 +9599,7 @@ var devToolsConfig$jscomp$inline_1056 = {
9599
9599
throwError("TestRenderer does not support findFiberByHostInstance()");
9600
9600
},
9601
9601
bundleType: 0,
9602
-
version: "18.3.0-canary-47beb96cc-20240222",
9602
+
version: "18.3.0-canary-d4cac3f96-20240222",
9603
9603
rendererPackageName: "react-test-renderer"
9604
9604
};
9605
9605
varinternals$jscomp$inline_1236={
@@ -9630,7 +9630,7 @@ var internals$jscomp$inline_1236 = {
0 commit comments