Skip to content

Commit d895539

Browse files
committed
[compiler] detect and throw on untransformed required features (#32512)
Traverse program after running compiler transform to find untransformed references to compiler features (e.g. `inferEffectDeps`, `fire`). Hard error to fail the babel pipeline when the compiler fails to transform these features to give predictable runtime semantics. Untransformed calls to functions like `fire` will throw at runtime anyways, so let's fail the build to catch these earlier. Note that with this fails the build *regardless of panicThreshold* DiffTrain build for [5398b71](5398b71)
1 parent 48bdd32 commit d895539

35 files changed

+513
-193
lines changed

compiled/eslint-plugin-react-hooks/index.js

Lines changed: 427 additions & 107 deletions
Large diffs are not rendered by default.

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5200721e5c93a59f8af0403d61abe513cb7d32fe
1+
5398b7115847e87c0053aa719728d8dd1a635ccd
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5200721e5c93a59f8af0403d61abe513cb7d32fe
1+
5398b7115847e87c0053aa719728d8dd1a635ccd

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,7 @@ __DEV__ &&
15321532
exports.useTransition = function () {
15331533
return resolveDispatcher().useTransition();
15341534
};
1535-
exports.version = "19.1.0-www-classic-5200721e-20250313";
1535+
exports.version = "19.1.0-www-classic-5398b711-20250314";
15361536
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371537
"function" ===
15381538
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,7 @@ __DEV__ &&
15321532
exports.useTransition = function () {
15331533
return resolveDispatcher().useTransition();
15341534
};
1535-
exports.version = "19.1.0-www-modern-5200721e-20250313";
1535+
exports.version = "19.1.0-www-modern-5398b711-20250314";
15361536
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371537
"function" ===
15381538
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
exports.useTransition = function () {
642642
return ReactSharedInternals.H.useTransition();
643643
};
644-
exports.version = "19.1.0-www-classic-5200721e-20250313";
644+
exports.version = "19.1.0-www-classic-5398b711-20250314";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
exports.useTransition = function () {
642642
return ReactSharedInternals.H.useTransition();
643643
};
644-
exports.version = "19.1.0-www-modern-5200721e-20250313";
644+
exports.version = "19.1.0-www-modern-5398b711-20250314";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
exports.useTransition = function () {
646646
return ReactSharedInternals.H.useTransition();
647647
};
648-
exports.version = "19.1.0-www-classic-5200721e-20250313";
648+
exports.version = "19.1.0-www-classic-5398b711-20250314";
649649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
650650
"function" ===
651651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
exports.useTransition = function () {
646646
return ReactSharedInternals.H.useTransition();
647647
};
648-
exports.version = "19.1.0-www-modern-5200721e-20250313";
648+
exports.version = "19.1.0-www-modern-5398b711-20250314";
649649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
650650
"function" ===
651651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18546,10 +18546,10 @@ __DEV__ &&
1854618546
(function () {
1854718547
var internals = {
1854818548
bundleType: 1,
18549-
version: "19.1.0-www-classic-5200721e-20250313",
18549+
version: "19.1.0-www-classic-5398b711-20250314",
1855018550
rendererPackageName: "react-art",
1855118551
currentDispatcherRef: ReactSharedInternals,
18552-
reconcilerVersion: "19.1.0-www-classic-5200721e-20250313"
18552+
reconcilerVersion: "19.1.0-www-classic-5398b711-20250314"
1855318553
};
1855418554
internals.overrideHookState = overrideHookState;
1855518555
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18583,7 +18583,7 @@ __DEV__ &&
1858318583
exports.Shape = Shape;
1858418584
exports.Surface = Surface;
1858518585
exports.Text = Text;
18586-
exports.version = "19.1.0-www-classic-5200721e-20250313";
18586+
exports.version = "19.1.0-www-classic-5398b711-20250314";
1858718587
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1858818588
"function" ===
1858918589
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)