Skip to content

Commit f629495

Browse files
authored
[Transition Tracing] Rename transitionCallbacks to unstable_transitionCallbacks (#24920)
Renaming transitionCallbacks to unstable_transitionCallbacks as per convention
1 parent 4bc83e6 commit f629495

File tree

3 files changed

+42
-18
lines changed

3 files changed

+42
-18
lines changed

packages/react-dom/src/client/ReactDOMRoot.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ export type RootType = {
2626
export type CreateRootOptions = {
2727
unstable_strictMode?: boolean,
2828
unstable_concurrentUpdatesByDefault?: boolean,
29+
unstable_transitionCallbacks?: TransitionTracingCallbacks,
2930
identifierPrefix?: string,
3031
onRecoverableError?: (error: mixed) => void,
31-
transitionCallbacks?: TransitionTracingCallbacks,
3232
...
3333
};
3434

@@ -216,8 +216,8 @@ export function createRoot(
216216
if (options.onRecoverableError !== undefined) {
217217
onRecoverableError = options.onRecoverableError;
218218
}
219-
if (options.transitionCallbacks !== undefined) {
220-
transitionCallbacks = options.transitionCallbacks;
219+
if (options.unstable_transitionCallbacks !== undefined) {
220+
transitionCallbacks = options.unstable_transitionCallbacks;
221221
}
222222
}
223223

packages/react-noop-renderer/src/createReactNoop.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ type TextInstance = {|
6868
|};
6969
type HostContext = Object;
7070
type CreateRootOptions = {
71-
transitionCallbacks?: TransitionTracingCallbacks,
71+
unstable_transitionCallbacks?: TransitionTracingCallbacks,
7272
...
7373
};
7474

@@ -828,8 +828,8 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
828828
false,
829829
'',
830830
onRecoverableError,
831-
options && options.transitionCallbacks
832-
? options.transitionCallbacks
831+
options && options.unstable_transitionCallbacks
832+
? options.unstable_transitionCallbacks
833833
: null,
834834
);
835835
return {

packages/react-reconciler/src/__tests__/ReactTransitionTracing-test.js

Lines changed: 36 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,9 @@ describe('ReactInteractionTracing', () => {
212212
);
213213
}
214214

215-
const root = ReactNoop.createRoot({transitionCallbacks});
215+
const root = ReactNoop.createRoot({
216+
unstable_transitionCallbacks: transitionCallbacks,
217+
});
216218
await act(async () => {
217219
root.render(<App navigate={false} />);
218220
ReactNoop.expire(1000);
@@ -276,7 +278,9 @@ describe('ReactInteractionTracing', () => {
276278
);
277279
}
278280

279-
const root = ReactNoop.createRoot({transitionCallbacks});
281+
const root = ReactNoop.createRoot({
282+
unstable_transitionCallbacks: transitionCallbacks,
283+
});
280284
await act(async () => {
281285
root.render(<App />);
282286
ReactNoop.expire(1000);
@@ -333,7 +337,9 @@ describe('ReactInteractionTracing', () => {
333337
);
334338
}
335339

336-
const root = ReactNoop.createRoot({transitionCallbacks});
340+
const root = ReactNoop.createRoot({
341+
unstable_transitionCallbacks: transitionCallbacks,
342+
});
337343
await act(async () => {
338344
root.render(<App />);
339345
ReactNoop.expire(1000);
@@ -404,7 +410,9 @@ describe('ReactInteractionTracing', () => {
404410
);
405411
}
406412

407-
const root = ReactNoop.createRoot({transitionCallbacks});
413+
const root = ReactNoop.createRoot({
414+
unstable_transitionCallbacks: transitionCallbacks,
415+
});
408416
await act(async () => {
409417
root.render(<App />);
410418
ReactNoop.expire(1000);
@@ -497,7 +505,9 @@ describe('ReactInteractionTracing', () => {
497505
);
498506
}
499507

500-
const root = ReactNoop.createRoot({transitionCallbacks});
508+
const root = ReactNoop.createRoot({
509+
unstable_transitionCallbacks: transitionCallbacks,
510+
});
501511
await act(async () => {
502512
root.render(<App />);
503513
ReactNoop.expire(1000);
@@ -602,7 +612,9 @@ describe('ReactInteractionTracing', () => {
602612
);
603613
}
604614

605-
const root = ReactNoop.createRoot({transitionCallbacks});
615+
const root = ReactNoop.createRoot({
616+
unstable_transitionCallbacks: transitionCallbacks,
617+
});
606618
await act(async () => {
607619
root.render(<App />);
608620
ReactNoop.expire(1000);
@@ -717,7 +729,9 @@ describe('ReactInteractionTracing', () => {
717729
);
718730
}
719731

720-
const root = ReactNoop.createRoot({transitionCallbacks});
732+
const root = ReactNoop.createRoot({
733+
unstable_transitionCallbacks: transitionCallbacks,
734+
});
721735
await act(async () => {
722736
root.render(<App />);
723737
ReactNoop.expire(1000);
@@ -846,7 +860,9 @@ describe('ReactInteractionTracing', () => {
846860
);
847861
}
848862

849-
const root = ReactNoop.createRoot({transitionCallbacks});
863+
const root = ReactNoop.createRoot({
864+
unstable_transitionCallbacks: transitionCallbacks,
865+
});
850866
await act(async () => {
851867
root.render(<App />);
852868
ReactNoop.expire(1000);
@@ -1000,7 +1016,9 @@ describe('ReactInteractionTracing', () => {
10001016
);
10011017
}
10021018

1003-
const root = ReactNoop.createRoot({transitionCallbacks});
1019+
const root = ReactNoop.createRoot({
1020+
unstable_transitionCallbacks: transitionCallbacks,
1021+
});
10041022
await act(async () => {
10051023
root.render(<App />);
10061024
ReactNoop.expire(1000);
@@ -1085,7 +1103,9 @@ describe('ReactInteractionTracing', () => {
10851103
);
10861104
}
10871105

1088-
const root = ReactNoop.createRoot({transitionCallbacks});
1106+
const root = ReactNoop.createRoot({
1107+
unstable_transitionCallbacks: transitionCallbacks,
1108+
});
10891109
await act(async () => {
10901110
root.render(<App />);
10911111
ReactNoop.expire(1000);
@@ -1203,7 +1223,9 @@ describe('ReactInteractionTracing', () => {
12031223
);
12041224
}
12051225

1206-
const root = ReactNoop.createRoot({transitionCallbacks});
1226+
const root = ReactNoop.createRoot({
1227+
unstable_transitionCallbacks: transitionCallbacks,
1228+
});
12071229
await act(async () => {
12081230
root.render(<App />);
12091231
ReactNoop.expire(1000);
@@ -1286,7 +1308,9 @@ describe('ReactInteractionTracing', () => {
12861308
);
12871309
}
12881310

1289-
const root = ReactNoop.createRoot({transitionCallbacks});
1311+
const root = ReactNoop.createRoot({
1312+
unstable_transitionCallbacks: transitionCallbacks,
1313+
});
12901314
await act(async () => {
12911315
startTransition(
12921316
() => root.render(<App markerName="one" markerKey="key" />),

0 commit comments

Comments
 (0)