Commit fb59833
committed
Restore old behavior for empty
Treat `<a href="" />` the same with and without
`enableFilterEmptyStringAttributesDOM`
in #18513 we started to warn and
ignore for empty `href` and `src` props since it usually hinted at a
mistake. However, for anchor tags there's a valid use case since `<a
href=""></a>` will by spec render a link to the current page. It could
be used to reload the page without having to rely on browser
affordances.
The implementation for Fizz is in the spirit of
#21153. I gated the fork behind
the flag so that the fork is DCE'd when the flag is off.
DiffTrain build for commit f3ce87a.href props on anchor tags (#28124)1 parent 040cfcd commit fb59833
File tree
7 files changed
+9
-9
lines changed- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
7 files changed
+9
-9
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25623 | 25623 | | |
25624 | 25624 | | |
25625 | 25625 | | |
25626 | | - | |
| 25626 | + | |
25627 | 25627 | | |
25628 | 25628 | | |
25629 | 25629 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9149 | 9149 | | |
9150 | 9150 | | |
9151 | 9151 | | |
9152 | | - | |
| 9152 | + | |
9153 | 9153 | | |
9154 | 9154 | | |
9155 | 9155 | | |
| |||
9180 | 9180 | | |
9181 | 9181 | | |
9182 | 9182 | | |
9183 | | - | |
| 9183 | + | |
9184 | 9184 | | |
9185 | 9185 | | |
9186 | 9186 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9577 | 9577 | | |
9578 | 9578 | | |
9579 | 9579 | | |
9580 | | - | |
| 9580 | + | |
9581 | 9581 | | |
9582 | 9582 | | |
9583 | 9583 | | |
| |||
9608 | 9608 | | |
9609 | 9609 | | |
9610 | 9610 | | |
9611 | | - | |
| 9611 | + | |
9612 | 9612 | | |
9613 | 9613 | | |
9614 | 9614 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
545 | 545 | | |
546 | 546 | | |
547 | 547 | | |
548 | | - | |
| 548 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
541 | 541 | | |
542 | 542 | | |
543 | 543 | | |
544 | | - | |
| 544 | + | |
545 | 545 | | |
546 | 546 | | |
547 | 547 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments