Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v8.x not allowed due to devEngines setting in package.json #10127

Closed
ndresx opened this issue Jul 9, 2017 · 3 comments
Closed

Node v8.x not allowed due to devEngines setting in package.json #10127

ndresx opened this issue Jul 9, 2017 · 3 comments

Comments

@ndresx
Copy link
Contributor

ndresx commented Jul 9, 2017

Do you want to request a feature or report a bug?
feature/update

What is the current behavior?
Currently, only the following Node versions are allowed because of the devEngines value in the package.json when executing npm install or any other script: "node": "4.x || 5.x || 6.x || 7.x".

Error:
Current node version is not supported for development, expected "8.0.0" to satisfy "4.x || 5.x || 6.x || 7.x".

What is the expected behavior?
Unless there is a reason for not allowing version 8 yet, could we update this?

@ndresx ndresx changed the title Node v8.x not allowed through devEngines in package.json Node v8.x not allowed due to devEngines setting in package.json Jul 9, 2017
@gaearon
Copy link
Collaborator

gaearon commented Jul 9, 2017

Wanna send a PR to add it there?

@ndresx
Copy link
Contributor Author

ndresx commented Jul 9, 2017

@gaearon yes sure, done!

@gaearon
Copy link
Collaborator

gaearon commented Jul 9, 2017

Fixed in #10129. Thanks for PR!

@gaearon gaearon closed this as completed Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants