-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncontrolled radio fix is breaking master #10196
Comments
Is there anymore info about what breaks and when? I imagine it's the instances vs DOM node check is failing but it's tough to guess why without a repro. |
We just got reports from production with the invariant triggering, it’s hard to say what exactly is being passed there. We’ll try to reproduce tomorrow. |
As a first step would you mind rewriting |
Left a few more questions in #10156 (review) |
I can definitely rewrite the tests, though for all intents and purposes the ChangeEventPlugin tests already do that. Which is to say, in terms of the public API the only visible effect is whether change events fire more than once per value. |
Hmmm I see. I was thinking about making tests still test implementation details (like wrappers) but use them through |
well it can't hurt :P I can see if it uncovers anything anyway |
Tracked down the cause. #10156 (comment) |
I'm not sure why but #10156 seems to have caused issues in production with us. We'll need to either revert or find a way to fix forward. Right now master is broken, and if we sync again before fixing, we'll break things.
The text was updated successfully, but these errors were encountered: