You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In step 4 of the Thinking in React example, the ProductTable component filters and displays an array of products based on user input.
I am unsure why the code for filtering the products is in the ProductTable component and not the FilterableProductTable component. The same question was previously raised in issue #8035.
I think having FilterableProductTable be responsible for filtering the products would improve the example for two reasons:
Allow ProductTable to be used outside of FilterableProductTable
Better separate the concerns of filtering the products from displaying the products
I updated the example and I'm happy to submit a PR if this is something that should be changed.
The text was updated successfully, but these errors were encountered:
The documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)
Please open a new issue in that repository. Sorry for the inconvenience!
In step 4 of the Thinking in React example, the
ProductTable
component filters and displays an array of products based on user input.I am unsure why the code for filtering the products is in the
ProductTable
component and not theFilterableProductTable
component. The same question was previously raised in issue #8035.I think having
FilterableProductTable
be responsible for filtering the products would improve the example for two reasons:ProductTable
to be used outside ofFilterableProductTable
I updated the example and I'm happy to submit a PR if this is something that should be changed.
The text was updated successfully, but these errors were encountered: