Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 Spillover #11088

Closed
5 of 16 tasks
gaearon opened this issue Oct 4, 2017 · 6 comments
Closed
5 of 16 tasks

React 16 Spillover #11088

gaearon opened this issue Oct 4, 2017 · 6 comments

Comments

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

Just dumping these items here since I want to close the 16 umbrella.

@reverofevil
Copy link

After years of having a message in documentation to use refs['abc'] instead of refs.abc to enable advanced optimization in Closure Compiler, React will finally support advanced optimization. Great news!

@ljharb
Copy link
Contributor

ljharb commented Oct 5, 2017

That will continue to be the case in your own code; the reference here is surely to build react itself with closure compiler's danger mode.

@reverofevil
Copy link

@ljharb Yes, that's already clear. The real problem is that it's often the case my code doesn't constitute the majority of the bundle.

@Jessidhia
Copy link
Contributor

Isn't the message in the documentation these days to not use the string refs and instead use a callback to save it to your own variable? 🤔

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

String refs are legacy, yes. They aren't the recommendation.

We advise against it because string refs have some issues, are considered legacy, and are likely to be removed in one of the future releases. If you’re currently using this.refs.textInput to access refs, we recommend the callback pattern instead.

source: https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 15, 2018

Stale.

@gaearon gaearon closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants