Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React.Children support for portals #11373

Closed
gaearon opened this issue Oct 26, 2017 · 3 comments
Closed

React.Children support for portals #11373

gaearon opened this issue Oct 26, 2017 · 3 comments
Labels
Component: Core Utilities Type: Discussion

Comments

@gaearon
Copy link
Collaborator

gaearon commented Oct 26, 2017

I don't think they're currently checked against. We should probably treat them same as elements.
@MatteoVH
Copy link

MatteoVH commented Oct 26, 2017 •
edited
Loading

Looking into taking this issue as a first source-code-touching PR, but I'm not sure if it's too much to take at once. If someone who knows what they're doing wants to take over, please let me know so I can look for something else to work on 😄

@MatteoVH MatteoVH mentioned this issue Oct 26, 2017
Merged
@gaearon
Copy link
Collaborator Author

gaearon commented Oct 26, 2017

See my comment in #11378 (comment). Curious if this is a breaking change.

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 31, 2017

Fixed by #11378.

@gaearon gaearon closed this as completed Oct 31, 2017
@MatteoVH MatteoVH mentioned this issue Oct 31, 2017
Closed
@japgolly japgolly mentioned this issue Dec 28, 2017
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core Utilities Type: Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @MatteoVH