Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Automatize tests on Windows environment && Circle CI 2.0 #11595

Closed
raphamorim opened this issue Nov 19, 2017 · 4 comments
Closed

[Question] Automatize tests on Windows environment && Circle CI 2.0 #11595

raphamorim opened this issue Nov 19, 2017 · 4 comments

Comments

@raphamorim
Copy link
Contributor

raphamorim commented Nov 19, 2017

Hi everyone,

I was wondering if it makes sense, implement the React Tests for windows environment. Even if it's to test only the build task (#9540, #9500) or only run for master branch. I was thinking of using the appveyor.

My other question is about migrate to Circle CI 2.0 configuration. If any of this questions make sense, I'll be available to implement it.

@raphamorim raphamorim changed the title Automatize windows partial package test [Question] Automatize tests on Windows environment && Circle CI 2.0 Nov 19, 2017
@FelicianoTech
Copy link

FelicianoTech commented Nov 20, 2017

Hey, I'm a Developer Evangelist from CircleCI.

I took a look at the current 1.0 config and it doesn't look too complicated. Shouldn't be too difficult to switch over to CircleCI 2.0 but ping me if any help is needed.

Unless you create a completely custom Docker image, a good start might be our Docker Ruby Images which have a variant that include NodeJS. The closest to what you're using now would be the circleci/ruby:2.2-node image which runs Ruby v2.2.8 and the LTS release of NodeJS.

@gaearon
Copy link
Collaborator

gaearon commented Nov 20, 2017

I'd be up for using AppVeyor but in my experience it can be pretty slow. Maybe it's fine if we only run it on master. (And if something fails, we'd know and investigate it post factum)

@raphamorim
Copy link
Contributor Author

The closest to what you're using now would be the circleci/ruby:2.2-node image which runs Ruby v2.2.8.

Thanks for the hint.

Maybe it's fine if we only run it on master

Sure.

Ok, leave it me. I'll send a PR.

@gaearon
Copy link
Collaborator

gaearon commented Nov 29, 2017

This is done now. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants