Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Providers (and maybe Consumers) show up as "Unknown" in Performance tab #12245

Closed
gaearon opened this issue Feb 18, 2018 · 5 comments
Closed

Comments

@gaearon
Copy link
Collaborator

gaearon commented Feb 18, 2018

Noticed this with 16.3 alpha:

screen shot 2018-02-18 at 21 58 15

I think we just need to support it here: https://github.com/facebook/react/blob/master/packages/shared/getComponentName.js.

Or else we could skip them here altogether.

@oantoro
Copy link

oantoro commented Feb 19, 2018

hello @gaearon
Is this issue beginner friendly?

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 19, 2018

Maybe (skipping them would be two lines) but we’ll need to do it soon so I can’t promise we’d wait for more then a few days.

@abhaynikam
Copy link
Contributor

abhaynikam commented Feb 19, 2018

@gaearon: I would love to contribute but I did not understand what we need to skip here?

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 19, 2018

Fibers with ContextProvider and ContextConsumer tags.

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 19, 2018

Fixed in #12250.

@gaearon gaearon closed this as completed Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants