Remove irrelevant suggestion of a legacy method from a warning #13169
Conversation
| 'be a pure function of props and state; constructor side-effects are ' + | ||
| 'an anti-pattern, but can be moved to `componentWillMount`.', | ||
| 'be a pure function of props and state. ' + | ||
| 'Move the setState call to componentDidMount`.', |
There was a problem hiding this comment.
This is too prescriptive. We don't actually know they called setState in constructor, or that they want to move it to cDM (setting it in constructor might be better in most cases).
There was a problem hiding this comment.
@gaearon I agree:) Whatever, i thought deprecated lifecycle error message should be deleted! As you say, I will fix pr by setting warn message by deleting message about prescriptive message (constructor and cDM)
There was a problem hiding this comment.
@gaearon is it ok?
| 'be a pure function of props and state; constructor side-effects are ' + | ||
| 'an anti-pattern, but can be moved to `componentWillMount`.', | ||
| 'be a pure function of props and state. ' + | ||
| 'Move the setState call to componentDidMount`.', |
There was a problem hiding this comment.
@gaearon I agree:) Whatever, i thought deprecated lifecycle error message should be deleted! As you say, I will fix pr by setting warn message by deleting message about prescriptive message (constructor and cDM)
| 'be a pure function of props and state; constructor side-effects are ' + | ||
| 'an anti-pattern, but can be moved to `componentWillMount`.', | ||
| 'be a pure function of props and state. ' + | ||
| 'Move the setState call to componentDidMount`.', |
There was a problem hiding this comment.
@gaearon is it ok?
Brew-Brew
changed the title
Brew-Brew
changed the title
|
Hi @zx6658 , |
gaearon
changed the title
As react version is updated and some lifecycle is deprecated, warn message should be changed like in my pr :)
Warning Content:
Cannot update during an existing state transition (such as withinrenderor another component's constructor). Render methods should be a pure function of props and state; constructor side-effects are an anti-pattern, but can be moved to componentWillMount.
What is the expected behavior?
I thought, warning messages what use deprecated lifecycle method should be changed!! :)