Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors thrown in gDSFP of a module-style context provider #13269

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 25, 2018

Context should be pushed before calling any user code, so if it errors the stack unwinds correctly.

Context should be pushed before calling any user code, so if it errors
the stack unwinds correctly.
Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Test is clear. 👍 for whatever it's worth.

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@acdlite acdlite merged commit bc1ea9c into facebook:master Jul 25, 2018
@acdlite
Copy link
Collaborator Author

acdlite commented Jul 25, 2018

@nhunzaker

Interesting.

Is it? Seems like the opposite to me

@nhunzaker
Copy link
Contributor

@acdlite Just pieces I don't interact with much. Fun to see how this stuff works.

segoddnja pushed a commit to segoddnja/react that referenced this pull request Aug 1, 2018
…ebook#13269)

Context should be pushed before calling any user code, so if it errors
the stack unwinds correctly.
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants