Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<noscript /> gives problems in IE8 #1341

Closed
sophiebits opened this issue Apr 1, 2014 · 7 comments
Closed

<noscript /> gives problems in IE8 #1341

sophiebits opened this issue Apr 1, 2014 · 7 comments

Comments

@sophiebits
Copy link
Collaborator

This throws an error in IE8 because the <noscript /> tag doesn't exist once rendered into the DOM:

/** @jsx React.DOM */

var Hello = React.createClass({
  render: function() {
    return (
      <div>
        {this.props.x ? <noscript /> : null}
      </div>
    );
  }
});

React.renderComponent(<Hello x={true} />, document.body);
React.renderComponent(<Hello x={false} />, document.body);

Thanks @matthewwithanm for pointing out a version of this.

@zpao
Copy link
Member

zpao commented Apr 1, 2014

Hmm, this is going to ruin some best laid plans for #888.

@sophiebits
Copy link
Collaborator Author

(I assume you mean #1058.)

@chenglou
Copy link
Contributor

chenglou commented Apr 2, 2014

Fixed internally to use script.

@matthewwithanm
Copy link
Contributor

@chenglou Is there a commit for this? What's done for server-side rendering?

@chenglou
Copy link
Contributor

chenglou commented Apr 2, 2014

@matthewwithanm ugh sorry, I meant for what spicyj was referring to

@syranide
Copy link
Contributor

This issue has already been resolved, except "not really": #1495

@syranide
Copy link
Contributor

@spicyj @zpao Fix for this landed some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants