Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction reference count decremented too aggressively #13574

Closed
5 tasks done
bvaughn opened this issue Sep 5, 2018 · 0 comments · Fixed by #13590
Closed
5 tasks done

Interaction reference count decremented too aggressively #13574

bvaughn opened this issue Sep 5, 2018 · 0 comments · Fixed by #13590

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Sep 5, 2018

Under certain conditions we decrement the __count attribute too often, which can result in onInteractionScheduledWorkCompleted being called prematurely and/or more than once for a given interaction.

  • Track interactions scheduled during (sync) render phase.
  • Do not double-decrement suspense loads within a sync render.
  • Do not decrement sync commits that are waiting on suspense when the Placeholder is past its expiration.
  • Properly decrement pending interaction count when a suspense resource loads before its placeholder is shown.
  • Add test with high priority render between suspended and resolved suspense states (for both sync and async rendering)
@bvaughn bvaughn self-assigned this Sep 5, 2018
@bvaughn bvaughn changed the title Interaction reference counting decremented too aggressively Interaction reference count decremented too aggressively Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants