Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][16.5] broke React Native for Web #13589

Closed
necolas opened this issue Sep 7, 2018 · 3 comments
Closed

[bug][16.5] broke React Native for Web #13589

necolas opened this issue Sep 7, 2018 · 3 comments
Assignees

Comments

@necolas
Copy link
Contributor

necolas commented Sep 7, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

React Native for Web was broken by 16.5 as describe here due to this change #13539

What is the expected behavior?

Release a version of React that exports the EventPluginHub.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

Worked in 16.4

@aweary
Copy link
Contributor

aweary commented Sep 7, 2018

On the topic, ReactDOMUnstableNativeDependencies exports injectComponentTree specifically for React Native for Web

// This is used by react-native-web.
export function injectComponentTree(ComponentTree) {
EventPluginUtils.setComponentTree(
ComponentTree.getFiberCurrentPropsFromNode,
ComponentTree.getInstanceFromNode,
ComponentTree.getNodeFromInstance,
);
}

But it doesn't appear to be used at all. Does this still need to be exposed?

@necolas
Copy link
Contributor Author

necolas commented Sep 7, 2018

You're right, that other API is not being used and I don't think it ever was. (I'm not sure what that API is for, i.e., whether it should be used for something)

@Tvrqvoise
Copy link

Tvrqvoise commented Sep 14, 2018

ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.EventPluginHub is still undefined in the latest release. Should this ticket be reopened?

I didn't see the changes in react-native-web#1106, which update RNW to use ReactDOMUnstableNativeDependencies to inject the plugin instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants