Fix a regression related to isReactComponent prototype check #13608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 03ab1ef...64c4e73 schedule
Generated by 🚫 dangerJS |
aweary
approved these changes
Sep 10, 2018
bvaughn
approved these changes
Sep 10, 2018
Merged
This was referenced Sep 14, 2018
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13580.
I didn't bother to add a warning since it would only point out legitimate problems for functional components that happen to have a prototype and
isReactComponenton it... which seems like very low probability. So we might as well allow shadowing.