Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-is memo #14278

Closed
aurimas4 opened this issue Nov 19, 2018 · 4 comments
Closed

react-is memo #14278

aurimas4 opened this issue Nov 19, 2018 · 4 comments
Labels
Type: Feature Request

Comments

@aurimas4
Copy link

Feature request

What is the current behavior?
react-is now doesn't have method to check if element is memo(like isForwardRef).
Maybe there are some reasons why it's not implemented?
@gaearon
Copy link
Collaborator

gaearon commented Nov 19, 2018

No particular reason, we could add it. What is your use case?

@Jessidhia
Copy link
Contributor

The only one that comes to mind, other than debug stuff, is avoiding double-wrapping with memo in a HOC factory, but that is something that React.memo itself could do (or maybe already does).

@aurimas4
Copy link
Author

I looked a little bit how could be implemented memo support in enzyme and found that enzyme adapter uses react-is library which doesn't support memo.

@jintoppy jintoppy mentioned this issue Nov 23, 2018
Merged
@bvaughn
Copy link
Contributor

bvaughn commented Dec 12, 2018

Resolved via #14313

@bvaughn bvaughn closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bvaughn @Jessidhia @gaearon @aurimas4