Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memo components show as Unknown in the timings section of Chrome #15897

Closed
xaviergonz opened this issue Jun 15, 2019 · 4 comments
Closed

memo components show as Unknown in the timings section of Chrome #15897

xaviergonz opened this issue Jun 15, 2019 · 4 comments
Labels
Resolution: Stale Automatically closed due to inactivity

Comments

@xaviergonz
Copy link

xaviergonz commented Jun 15, 2019

Do you want to request a feature or report a bug?
bug report

What is the current behavior?

Given a component like

export const MyComponent = (p) => {...};
MyComponent.displayName = "MyComponent";

it shows properly as
image

but as soon as memo is added

export const MyComponent = memo((p) => {...});
MyComponent.displayName = "MyComponent";

it shows as Unknown instead
image

Note that both actually show properly on the tree explorer, the issue is only in the timings section of a performance recording in chrome.

What is the expected behavior?

It should show the proper name on the timings when memo is used

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

Windows 10, Chrome 74, React 16.8.x (the latest version that was available on April 26)

This issue got copied from react devtools repo since @bvaughn suggested it was actually a react bug
facebook/react-devtools#1340

@eps1lon
Copy link
Collaborator

eps1lon commented Jun 15, 2019

This should be covered by #15313

@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 17, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jan 17, 2020
@alflennik
Copy link

I just ran into this issue - it is still occurring and should be reopened. The linked PR also hasn't yet been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

No branches or pull requests

3 participants