-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevTools: Fully disable 0.14 support #16462
Comments
I can take a look if nobody started on this one yet :) |
It's all yours @danielhusar. Please let me know if you decide not to work on it for any reason, and I'll remove the "taken" label 😄 |
@bvaughn Hey! Is there an easy way to get react version? It's also possible I'm looking into a totally wrong place :) |
I think you would have to feature detect it. Here's how the legacy extension did it: Based on this, I think checking for |
@bvaughn I have very early PR #16720 , would you be able to check if I'm remotely going in right direction? It's my first time in codebase and I'm bit struggling. I think I have the check for the extension there, but I have hardcoded values for standalone | frontend, as I haven't tracked down where to put those checks yet. I was looking into adding some logic also inside |
I've written some documentation about how the operations array works here, if it's helpful: I left a few comments on the PR. |
Hi @danielhusar! It's been a couple of weeks since the PR has been updated, so I'm going to remove the "taken" label for now. Let me know if you pick this back up though! |
Sorry, been pretty busy with deadlines lately :( |
It's fine :) Just wanted to free it up for someone else (maybe even me) to take a look. |
This fix has just been published to NPM and posted to Chrome/Firefox as v4.1.1 |
It’s confusing that 0.14 or earlier is in half-working state where it displays a tree (but incorrectly). We should detect it and fully disable if it doesn’t work. Or fix it.
If we go the route of disabling support:
Originally reported by @gaearon via bvaughn/react-devtools-experimental#384
The text was updated successfully, but these errors were encountered: