Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Improve HOC search UX #16467

Closed
bvaughn opened this issue Aug 19, 2019 · 1 comment · Fixed by #18802
Closed

DevTools: Improve HOC search UX #16467

bvaughn opened this issue Aug 19, 2019 · 1 comment · Fixed by #18802
Labels
Component: Developer Tools React Core Team Opened by a member of the React Core Team Type: Enhancement

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Aug 19, 2019

Building on top of #360

We could probably improve the search UX in a couple of ways:

  • Visually indicate when the "match" is because of a HOC name, e.g.

Screen Shot 2019-08-03 at 1 54 21 PM

  • Match built-in HOC types (e.g. searching "me" should match React.memo HOCs, searching "f" should match React.forwardRef, etc.)

Originally reported via bvaughn/react-devtools-experimental#365
@bvaughn bvaughn mentioned this issue Aug 19, 2019
Closed
@SavePointSam
Copy link
Contributor

Looks like the link to the old PR doesn't work. The above message refers to bvaughn/react-devtools-experimental#360.

@necolas necolas added the React Core Team Opened by a member of the React Core Team label Jan 8, 2020
@bl00mber bl00mber mentioned this issue May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Developer Tools React Core Team Opened by a member of the React Core Team Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DevTools] Improve HOC search UX bl00mber/react
3 participants
@bvaughn @necolas @SavePointSam