Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Updating state or props in devtools does not trigger component update. #17305

Closed
thisisDom opened this issue Nov 7, 2019 · 5 comments

Comments

@thisisDom
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?

Changing state or props for a component in React-Devtools isn't updating component.

What is the expected behavior?

Component should reflect changes made to state/props in React-Devtools

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

Using React-Devtools v4 w/ React 16.9
Working in v3 of React-Devtools

@thisisDom thisisDom changed the title DevTools: Updating state or props in devtools does not trigger state. DevTools: Updating state or props in devtools does not trigger component update. Nov 7, 2019
@threepointone
Copy link
Contributor

This needs more information than just saying it doesn't work. Could you use codesandbox to make a reproducing example?

@thisisDom
Copy link
Author

thisisDom commented Nov 7, 2019

Here is the codesandbox I used:
https://codesandbox.io/s/y2lrywpk21

I changed the value of state.text to "test" in React-Devtools but the change isn't reflected in the input field. I uploaded a screenshot below.

https://www.dropbox.com/s/jfjak9t32lyv599/Screen%20Shot%202019-11-07%20at%203.46.26%20PM.png?dl=0

@hristo-kanchev
Copy link
Contributor

@thisisDom I can't reproduce the issue.
Did you by any chance forgot to press Enter after you entered the text?

@thisisDom
Copy link
Author

Yeah looks like that was my issue. In the previous version, I could click out of the console and it would update. Thank you

@hristo-kanchev
Copy link
Contributor

@thisisDom We have a PR open for this #17062 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants