Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastNativeEvent retains unmounted elements & fibers #17580

Closed
bgirard opened this issue Dec 12, 2019 · 2 comments
Closed

lastNativeEvent retains unmounted elements & fibers #17580

bgirard opened this issue Dec 12, 2019 · 2 comments

Comments

@bgirard
Copy link
Contributor

bgirard commented Dec 12, 2019

I'm seeing memory kept around for longer then it needs to by lastNativeEvent:

In my case it's holding on to detached DOM nodes/Fiber.

I think we should be able to use WeakSet since we're doing a === check. Otherwise we should consider timing it out in some way.

@bgirard
Copy link
Contributor Author

bgirard commented Dec 12, 2019

Related #17006

@bgirard
Copy link
Contributor Author

bgirard commented Dec 14, 2019

Fixed by #17585

@bgirard bgirard closed this as completed Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants