We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref: reactjs/rfcs#147 (comment)
React version: 0.0.0-experimental-e5d06e34b
Link to code example:
https://codesandbox.io/s/jovial-dew-1eg4t?file=/src/App.js
If getSnapshot returns a function, it will run the function in render. This results in various errors.
My workaround: return an object wrapping a function, and destruct on caller.
For now, you can work around this by returning a function that returns your function
I don't know how this works as workaround.
It would be nice if returning a function just works.
Note: this is not a rare use case in my library https://github.com/dai-shi/use-context-selector because we often pass [state, setState] in a context value.
[state, setState]
The text was updated successfully, but these errors were encountered:
Thanks. Understood. I'd try not-100%-safe workaround in my lib, or let the lib users do a workaround.
Sorry, something went wrong.
Thanks for understanding!
(For those who might come here later,) here's my workaround: dai-shi/use-context-selector@2fcf1a2#diff-f41e9d04a45c83f3b6f6e630f10117fe
Successfully merging a pull request may close this issue.
Ref: reactjs/rfcs#147 (comment)
React version: 0.0.0-experimental-e5d06e34b
Steps To Reproduce
Link to code example:
https://codesandbox.io/s/jovial-dew-1eg4t?file=/src/App.js
The current behavior
If getSnapshot returns a function, it will run the function in render. This results in various errors.
My workaround: return an object wrapping a function, and destruct on caller.
I don't know how this works as workaround.
The expected behavior
It would be nice if returning a function just works.
Note: this is not a rare use case in my library https://github.com/dai-shi/use-context-selector
because we often pass
[state, setState]
in a context value.The text was updated successfully, but these errors were encountered: