-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify application when JSXTransformer has completed processing JSX #1913
Comments
Just a side-note, I really recommend that you use the |
@RReverser if you're really interested in doing this, I don't mind. I think this is slightly more practical than #1995, but it still could encourage the wrong behavior. What do you think? |
@zpao Well, if you're going to combine functionality of |
I think the combining might end up being a bit more of a convergence. These things overlap a lot with slight API differences. The other big difference is that JSXTransformer finds script tags. I was considering smoothing out API differences, then having JSXTransformer be the browserify override. Any new functionality we add to JSXTransformer now would in turn make it to the new place too. |
If you need this, I believe you can add
or similar after the external script tags and that will queue it correctly. |
As first discussed in #1558 (comment) .
Use case: Application code is in
app.js
; react code is in fileui.jsx
. In development, both are included along withJSXTransformer
. There's no way forapp.js
to reliably reference components defined inui.jsx
. (In production, JSX is first translated, then all JS files are combined/compiled together, so this is not an issue.)As noted in the above comment, there are workarounds.
The text was updated successfully, but these errors were encountered: