-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to DevTools to enable double-logging #19666
Comments
I could take this up! |
Sounds good. |
@gaearon i need more light on how to go about this. I have created the UI already #19710 but pretty confused on how to get the boolean value in packages/shared/ConsolePatchingDev.js. Or am i to do the manipulation here https://github.com/facebook/react/blob/master/packages/react-devtools-shared/src/backend/console.js |
@Jchinonso Are you working on the PR? If you are busy do you mind if I take it up? |
@todortotev PR is up already #19710 |
Apologies! My bad! Good work! |
No worries |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
@Stale It' still relevant |
Fixed by #22030
|
We currently plan to suppress double-logging in development by overriding console in 17: #18547
However this can be confusing for some scenarios and double logging may be preferable in them.
Ideally we'd add a toggle to DevTools that would allow to re-enable it on this screen:
The text was updated successfully, but these errors were encountered: