Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-dom 17 breaks on internet explorer #20069

Closed
jsumnerp opened this issue Oct 21, 2020 · 5 comments · Fixed by #20071
Closed

react-dom 17 breaks on internet explorer #20069

jsumnerp opened this issue Oct 21, 2020 · 5 comments · Fixed by #20071

Comments

@jsumnerp
Copy link

After updating react-dom to version 17 the build now includes Array.fill() which isn't supported by ie11 without polyfilling. Coming from this line. Tested with just the default cra production build to make sure it wasn't a problem with my webpack config and the same issue.

return new Array(TotalLanes).fill(initial);

Tested using CRA on version 16.9.8 of react and react-dom which works with the production build for ie11.

@eps1lon
Copy link
Collaborator

eps1lon commented Oct 21, 2020

Confirmed with https://csb-hznfc-77macj50y.vercel.app/ (built from https://codesandbox.io/s/cranky-glitter-hznfc?file=/package.json) which errors with "SCRIPT438: Object doesn't support property or method 'fill'".

@gaearon
Copy link
Collaborator

gaearon commented Oct 21, 2020

#20071

@gaearon
Copy link
Collaborator

gaearon commented Oct 21, 2020

@eps1lon Any chance you could confirm the fix on a real IE

@gaearon
Copy link
Collaborator

gaearon commented Oct 21, 2020

Gonna wait to see if a few more bugs get reported in the next few hours. Then will cut a patch.

@gaearon
Copy link
Collaborator

gaearon commented Oct 22, 2020

Should be fixed in 17.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants