[eslint-plugin-react-hooks] Bug: ESLint crashes if there's a useEffect / useLayoutEffect invocation without any arguments.

[latin-1]

eslint-plugin-react-hooks version: 4.2.0

Steps To Reproduce

I know it shouldn't exist in production code, but it's annoying while editing some files.

import React, { useEffect } from "react";

const App = () => {
  useEffect(); // <-
  return null;
};

export default App;

Link to code example: https://codesandbox.io/s/polished-sun-3wr27?file=/src/App.js

The current behavior

ESLint crashed.

TypeError: Cannot read property 'type' of undefined

The expected behavior

ESLint doesn't crash but reports an error instead.

[dcastil]

I have the same issue, too. It's very annoying to get this warning any time I type useEffect() in VS Code.

Thanks for fixing this! 🙏

[rickhanlonii]

Thanks @ChrisRu for the fix!

[Alecell]

I'm currently facing that error too and the case is the same that when the hook is empty, am I doing something wrong?

"eslint": "^7.27.0",
"eslint-plugin-react": "^7.24.0",
"eslint-plugin-react-hooks": "^4.2.0",

[dcastil]

@Alecell eslint-plugin-react-hooks did not release a new version since this PR was merged. We need to wait until a new version of it gets released (I'm waiting for the release too 😄).

You can use the same workaround as me in the meantime, a code snippet for useEffect:

{
    "React useEffect": {
        "scope": "javascript,javascriptreact,typescript,typescriptreact",
        "prefix": "use effect",
        "body": ["useEffect(() => {$0})"]
    }
}

Then you can create effects by typing ue in a js/ts file.

You can read more about how to create snippets in VS Code here: https://code.visualstudio.com/docs/editor/userdefinedsnippets