New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flushSync should change priority of commit phase updates to sync, even though it can't flush them immediately #21111

Closed

acdlite opened this issue Mar 26, 2021 · 0 comments · Fixed by #21122

Collaborator

acdlite commented Mar 26, 2021

flushSync early returns if it detects it's in the commit (or render) phase, since it can't synchronously flush when React is already working.

However, it should still change the priority of updates scheduled by the callback to be synchronous.

This mostly already works because the commit phase itself has a sync event priority context, but the passive effect phase doesn't.

Need more tests for this.

acdlite linked a pull request

that will close this issue

Fix: flushSync changes priority inside effect #21122

Merged

acdlite closed this as completed in #21122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment