Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: createBlockingRoot doesn't exist on react-dom@0.0.0-experimental-af1a4cbf7 #21316

Closed
natew opened this issue Apr 19, 2021 · 2 comments
Closed
Labels
Component: Concurrent Features Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@natew
Copy link

natew commented Apr 19, 2021

React version: 0.0.0-experimental-af1a4cbf7

Pretty simple, seems to just be missing entirely. Searching around I don't see any obvious commits or even tweets/notes on this, but the docs on the live site indicate it exists.

@natew natew added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Apr 19, 2021
@eps1lon
Copy link
Collaborator

eps1lon commented Apr 19, 2021

unstable_createBlockingRoot was removed in #20974.

Removing the mention from the docs entirely might be confusing. A note about it under https://reactjs.org/docs/concurrent-mode-reference.html#createblockingroot should work. Though I don't know if the core team intends to write something about the reasoing or if "it was removed" is sufficient. Maybe @rickhanlonii has an opinion about it.

@bvaughn
Copy link
Contributor

bvaughn commented Apr 19, 2021

createBlockingRoot was an unstable API that we determined was not necessary for a stable release. The docs in question do mention right at the top that all APIs are experimental and unstable.
Screen Shot 2021-04-19 at 4 24 41 PM

We will have stable docs for the final/stable API by the time we release it to the stable NPM channel though 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Concurrent Features Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

3 participants