Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools Bug]: Children list grows indefinitely when adding/removing useEffect #21469

Closed
eps1lon opened this issue May 8, 2021 · 3 comments
Closed
Assignees
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug

Comments

@eps1lon
Copy link
Collaborator

eps1lon commented May 8, 2021

Website or app

Please checkout the linked branch not main
https://github.com/eps1lon/react-devtools-repro-no-matching-node/tree/repro/elements-leaking
Repro steps and screen recording included in the repro

Repro steps

  1. Clone repro
  2. yarn
  3. yarn start
  4. Open app page
  5. open devtools
  6. Uncomment the useEffect block i.e. add an effect
  7. inspect Component element
  8. comment useEffect block i.e. remove the effect
  9. Repeat comment/uncomment to see that children grow indefinitely

How often does this bug happen?

Every time

DevTools package (automated)

No response

DevTools version (automated)

No response

Error message (automated)

Could not inspect element with id 4

Error call stack (automated)

No response

Error component stack (automated)

No response

GitHub query string (automated)

No response

Might be a duplicate of #21436 (comment) since the repro steps are the same. But depending on what the effect is doing, the behavior is different.

@eps1lon eps1lon added Type: Bug Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Component: Developer Tools labels May 8, 2021
@eps1lon eps1lon changed the title [DevTools Bug]: [DevTools Bug]: Children list grows indefinitely when adding/removing useEffect May 8, 2021
@bvaughn bvaughn self-assigned this May 9, 2021
@bvaughn
Copy link
Contributor

bvaughn commented May 13, 2021

I think this might be the same issue I've captured in a test:
#21436 (comment)

@bvaughn
Copy link
Contributor

bvaughn commented May 13, 2021

I think #21506 might be one way to fix this issue.

@bvaughn
Copy link
Contributor

bvaughn commented May 18, 2021

Resolved by #21516

@bvaughn bvaughn closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants