-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTools Bug] Cannot add node "1" because a node with that id is already in the Store. #23226
Comments
Hey! Thanks for reporting this issue, and I'm really sorry you encountered it. However, without a repro case we're not able to address this. Could you create a codesandbox or a create-react-app repro case for us so we can debug and fix your issue? Thanks! |
I believe this is the same issue as reported in RN Debugger GH: jhen0409/react-native-debugger#668 |
i am facing this issue please guide me whats a problem in my devtools............. ................................................. The error was thrown at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26229:41 |
I have the same issue, any ideas what should we do? Thanks a lot. |
le même problème. |
I have the same issue in my project
|
I'm also having the same problem. |
Same issue for me - RN v0.64.3 RND v0.12.1 |
I see this issue is recent. Idk what the outcome of this will be, but I've avoid getting this error. ar.map((obj, index) => ... ) if so, try to avoid it. dont use index as key. give your object an id or other kind of unique identifier as key prop. |
I am facing this same issue, I have upgraded both react-devtools and react-devtools-core to 4.23.0, and we are not using index as a key anywhere in our codebase. |
OK, I have fixed this for myself by adding this into our package.json:
|
thank you @MalinnaLeach you helped me as well |
|
Also facing this issue |
We can't help without a reproducing case. Please only add a comment if you can provide one. Thanks! |
I am also having this issue. Steps I used to reproduce:
Here is my repository: https://github.com/jlordi70/ReactNativeDebuggerIssue.git Please let me know if you need any other information. Thank You In Advance! |
This is happening to me while having Seems like having two devtool instances attached to the same app is also causing this bug. |
For those of you on React Native with this issue, this could be because your DevTools backend in React Native ( We have a PR out that warns if the DevTools backend and front end versions mismatch, but it's only available as of v4.24.3 so you might not see if it you are on older versions. |
I'm also having the same problem. |
Guessing a lot of folks are commenting without a repro because the debugger is linking to this issue with instructions to add a comment in large bold font, easy to miss the rest about providing a repro case and it's a confusing bug. For React Native npm users that can't use the resolutions workaround mentioned elsewhere (only works for yarn), try installing the devtools and core direct in your project (not global):
It's possible you may only need the core package, but installing both didn't hurt for me. |
I tried that and it still did not work. I provided a repo above: https://github.com/jlordi70/ReactNativeDebuggerIssue.git Package,json file |
@lunaruan https://github.com/jlordi70/ReactNativeDebuggerIssue.git |
I am also facing the same issue |
@jlordi70 I tried to reproduce the issue with your repro case but I couldn't. Could you manually upgrade both your |
Hey everyone!!! |
In my case reinstalling of react-native-debuger to newer version solved the issue
If you face permission issue, just remove debugger manually and reinstall |
This is new as of either 4.27.0 or 4.27.1 as I haven't changed any code in the repo since Nov 18 when I was using 4.26.1 to record a course. You can see a snapshot preview site here where there are issues. Specifically, this issue seems to be random -- I only saw it once, but I think it's due to the devtools not loading immediately and timing out. To reproduce:
VideoI recorded a clip because it's BONKERS to try and describe 😄 Bonus.-.Debugging.the.DevTools.mp4ScreenshotsDevTools greyed out initially (not always the case but happens during the video) And when it does work, I started seeing another issue while debugging the app (couldn't repro in video): WorkaroundI noticed if I click the React extension icon a few times with the developer tools open, it loads much faster and doesn't time out 🤔 I am using CRA with Chrome Devtools, no RN at all.
As for the root cause, I don't know exactly but if I had to bet 💰 then my bet is on this (big PR, new feature, device storage related, possible async/timeout issues): #25452 edit: I looked around at the commits/PRs and did some limited testing but I'm not so sure now, maybe it was introduced elsewhere. Hope that helps @gaearon! I can confirm on my separate Chrome profile using 4.25.0 everything is working, so I will plan to revert to that in the meantime. |
Now that I see it, between 4.25.0 and 4.27.1, there was an update to the V3 manifest: That could explain the issue. For now I am using unpacked 4.25.0, from crx4chrome. |
In my case this solution has worked for me |
I got this error but I turned off the extension, closed the browser, reopened the browser, turned the extension back on, and then it worked! |
I was able to replicate this error iff I opened my developer menu in Chrome on the test site. Closing the developer panel and refreshing got rid of the issue |
Still happening with 4.27.7. Besides the not showing right away (opening/closing the dev tools fixes this), it was working for about an hour and a half. Came back tonight (6 hours later) and now it won't work, it just times out on every single inspected component. I didn't do anything between then and now. So it's weird that it starts to happen over time suggesting some kind of leak. PS. I'm not alone it seems This might just warrant a new issue to decouple it from React Native since these are from the Chrome web store review section. |
Repro steps
"react": "17.0.2",
"react-native": "0.66.3",
"react-devtools": "^4.22.0",
"@react-navigation/devtools": "^6.0.5",
"@react-navigation/bottom-tabs": "^6.1.0",
"@react-navigation/core": "^6.1.1",
"@react-navigation/elements": "^1.3.0",
"@react-navigation/native": "^6.0.7",
"@react-navigation/native-stack": "^6.3.0",
"@react-navigation/routers": "^6.1.0",
"@react-navigation/stack": "^6.1.0",
How often does this bug happen?
Every time
DevTools package (automated)
react-devtools-core
DevTools version (automated)
4.14.0-d0ec283819
Error message (automated)
Cannot add node "1" because a node with that id is already in the Store.
Error call stack (automated)
Error component stack (automated)
No response
GitHub query string (automated)
The text was updated successfully, but these errors were encountered: