-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on initializeTouchEvents
, removing tap-delay
#2468
Comments
+1 |
Yeah, it makes it sound that it will actually use touch events which is does not. |
+1. At the moment, as of React 0.12 on my project, touch events still trigger on touch devices with or without initializeTouchEvents. |
I'm also curious what this would be used for. I'm loading my react app in a ios simulator and things seem ok without explicitly setting initializeTouchEvents to true. To be fair I haven't tried on an actual device. |
|
BTW docs sources are fixed https://github.com/facebook/react/pull/3442/files#diff-8949552676e903f486caef00b60d5630L144 |
@chicoxyzzy @jefffriesen I still see note about
|
@iamstarkov looks like the version with fixes is not shipped yet |
The documentation on
React.initializeTouchEvents(true)
could use a little love:http://facebook.github.io/react/docs/events.html#touch-events
I realize it's currently changing and may be removed (#436, #1170). Is it still required? Is it only required if we use react-tap-event-plugin?
What's most confusing about it is when to use it. Use it if the page being rendered will ever render on a touch device? Or do we detect touch using something like
Modernir.touch
and then set it to true?Related to this issue is the tap delay. Maybe suggest in the documentation using a plugin like tap-event-plugin?
I would submit a PR but really don't know what the documentation should say. Thanks!
The text was updated successfully, but these errors were encountered: