Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix direct uses of document and global #373

Closed
zpao opened this issue Sep 25, 2013 · 4 comments
Closed

Fix direct uses of document and global #373

zpao opened this issue Sep 25, 2013 · 4 comments
Milestone
v0.5

Comments

@zpao
Copy link
Member

zpao commented Sep 25, 2013

8f15eea introduced a couple uses. We need to fix them because

  1. global isn't actually available (though we need to be careful about using window directly as well - 458836a)
  2. document breaks server rendering - ReferenceError: document is not defined facebookarchive/react-page#28
@sophiebits
Copy link
Collaborator

Also we're trying to make rendering into iframes work, so document is probably usually/always the wrong thing to use?

@zpao
Copy link
Member Author

zpao commented Sep 26, 2013

84dea7e fixed some of this.

@petehunt
Copy link
Contributor

+1 @spicyj

@zpao zpao mentioned this issue Oct 15, 2013
Closed
@zpao
Copy link
Member Author

zpao commented Oct 15, 2013

Closing this out - no need to keep the general issue around.

@zpao zpao closed this as completed Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
3 participants
@sophiebits @zpao @petehunt