Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 block change events if disabled #4457

Closed
brigand opened this issue Jul 22, 2015 · 7 comments
Closed

IE11 block change events if disabled #4457

brigand opened this issue Jul 22, 2015 · 7 comments

Comments

@brigand
Copy link
Contributor

brigand commented Jul 22, 2015

Repro: https://jsbin.com/gebasa/3/edit?js,output

Given:

<input 
  disabled={true}
  type="checkbox"
  checked={trueOrFalse} 
  onChange={alert} 
  />

On at least IE11 a double click on checkbox causes onChange to be called. If it's just adding an if statement, normalizing this would be nice. It may also affect other elements/events like <button disabled onClick={f}>, misc screen readers, etc.

Workaround: duplicate the disabled boolean logic in the handler.

The report was from sim1234 on IRC and verified by phi0x.

@zpao
Copy link
Member

zpao commented Jul 24, 2015

I think we already have some logic to disable this for buttons, should be doable.

@johansuperstar
Copy link

What's the status on this? Experienced the same issue today using React v.0.13.3 in IE11.

@scvnc
Copy link

scvnc commented Dec 2, 2015

I am also experiencing this disabled double-click checkbox behavior in React 0.14.3 and IE11, 10, 9. https://jsbin.com/mezujo/edit?html,js,output

@janusch
Copy link

janusch commented May 10, 2016

Just a short update that this is still an issue in react 15.0.1 . So if you want to disable double clicks in IE on checkboxes a workaround is the one mentioned by @brigand above. Thank you!

@jimfb
Copy link
Contributor

jimfb commented May 10, 2016

PRs welcomed.

@gaearon
Copy link
Collaborator

gaearon commented May 10, 2016

AFAIK this was fixed by #6215.
It should be a part of 15.0.2 (not 15.0.1, so @janusch you’ll need to update).

@hdpinto
Copy link

hdpinto commented Dec 15, 2017

I'm still experiencing this issue on v15.5.4 using radio inputs. What version was this fixed on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants