Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save flag someplace if checksum was invalid #5924

Closed
catmando opened this issue Jan 26, 2016 · 1 comment
Closed

save flag someplace if checksum was invalid #5924

catmando opened this issue Jan 26, 2016 · 1 comment

Comments

@catmando
Copy link

we have tests that insure that prerendering = client rendering.

Right now its a real cludge - we override console.warn, and watch to see if any checksum warnings are output.

Instead how about adding data-checksum_invalid to the outer element?

@jimfb jimfb mentioned this issue Jan 27, 2016
5 tasks
@catmando catmando changed the title save flag someplace is checksum was invalid save flag someplace if checksum was invalid Jan 27, 2016
@gaearon
Copy link
Collaborator

gaearon commented Oct 3, 2017

We don’t have checksum warning checks now, but we still use console.error to notify about the differences.

We might add a way to hook into the warning system later. Let’s track it in #4302.

@gaearon gaearon closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants