Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg clipPath has wrong namespace #6012

Closed
IL55 opened this issue Feb 10, 2016 · 4 comments
Closed

svg clipPath has wrong namespace #6012

IL55 opened this issue Feb 10, 2016 · 4 comments

Comments

@IL55
Copy link

IL55 commented Feb 10, 2016

Hi,
when svg.clipPath created "dynamically" (i.e. via button click) has wrong namespace
more details here https://jsfiddle.net/ceejpt0z/16/
(press button Add new center)

For test I use React 0.14.7 (is it latest react ?)
I thought, that it should work, thanks this pull request
#5714

I see that clipPath added here (and circle too):
https://github.com/facebook/react/blob/master/src/isomorphic/classic/element/ReactDOMFactories.js#L155

And circle works OK but clipPath - no.

@jimfb
Copy link
Contributor

jimfb commented Feb 10, 2016

Try it in this fiddle: http://jsfiddle.net/9kungxn4/

Also, in your fiddle, you're trying to map over a prop that you never pass in, thus the error.

@IL55
Copy link
Author

IL55 commented Feb 10, 2016

for your fiddle it works ok, so for new react it solved
could you recommend me some patch for 14.7 react (since it is stable react) ?
Here is fiddle for new react: http://jsfiddle.net/om4jjoq2/2/,
I also updated link in original message (sorry bad fiddle)

@jimfb
Copy link
Contributor

jimfb commented Feb 10, 2016

Ok, I'm going to close, since it's fixed in master.

You could try cherry-picking some commits over, but honestly, I would recommend just waiting for 0.15 to be released. If you're really in a hurry to play with it, you could try using a future build (eg. http://jimsproch.com/react/future/), but you should be aware that we don't guarantee that it will be stable.

@jimfb jimfb closed this as completed Feb 10, 2016
@IL55
Copy link
Author

IL55 commented Feb 10, 2016

Thanks, I found that it can be fixed for 0.14.7 via dangerouslySetInnerHTML. So no problem for now and thanks guys for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants