Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactTestUtils.Simulate logs unexpected console error #6379

Closed
harboecp opened this issue Mar 30, 2016 · 3 comments · Fixed by #6380
Closed

ReactTestUtils.Simulate logs unexpected console error #6379

harboecp opened this issue Mar 30, 2016 · 3 comments · Fixed by #6380
Milestone

Comments

@harboecp
Copy link

To reproduce, open http://jsfiddle.net/0jjnaghw/
Error is logged to browser dev tools (in Chrome & Firefox, somehow not in Safari).

Happens on v15.0.0-rc.2 and on latest master version.

The assignment of additional event data to the newly created SyntheticEvent triggers a console error:

assign(event, eventData);

"Warning: This synthetic event is reused for performance reasons."

@zpao zpao added this to the 15.0 milestone Mar 30, 2016
@zpao
Copy link
Member

zpao commented Mar 30, 2016

Thanks for reporting. We'll get this fixed.

@gaearon
Copy link
Collaborator

gaearon commented Mar 30, 2016

Are we not checking for unexpected warnings in tests? Should we? Curious how this crept in unnoticed.

@zpao
Copy link
Member

zpao commented Mar 30, 2016

node doesn't support Proxies so none of that code is actually getting tested :/ Even running with --harmony flag (which we do at least with grunt test) doesn't enable it since it's "in progress". We could probably run with --harmony_proxies to force it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@zpao @gaearon @harboecp and others