Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key warnings should show component stack #6790

Closed
sophiebits opened this issue May 17, 2016 · 0 comments
Closed

Key warnings should show component stack #6790

sophiebits opened this issue May 17, 2016 · 0 comments
Assignees

Comments

@sophiebits
Copy link
Collaborator

In #6771 I made it so that proptypes warnings show the stack of components where the warning occurred. We should do the same for key warnings (when no key is provided):

Each child in an array or iterator should have a unique "key" prop.

It shouldn't be too hard to use ReactComponentTreeDevtool.getCurrentStackAddendum in the same way that proptypes warnings are now using it and to update the unit tests so that they pass with the new format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants