[Flight] Serialize Error Values #31104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
flightlogerror
branch
from
c7d97af to
775defa
Compare
|
Does this also work for Actions that return error objects e.g. during form validation? |
|
Yes. But not very useful since its message will be hidden in prod. |
13 tasks
eps1lon
approved these changes
Sep 30, 2024
|
Will people write code that does that in dev and then be sad when it breaks in prod? |
We got this feedback already for thrown errors from Server Actions. @gnoff mentioned that we always want to include a notice in the error message that it'll be stripped in prod to prevent relying on messages for prod behavior. But we didn't follow-up. Might worth bringing this up again. |
This was referenced Oct 1, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that the RSC protocol is a superset of Structured Clone. #25687 One exception that we left out was serializing Error objects as values. We serialize "throws" or "rejections" as Error (regardless of their type) but not Error values.
This fixes that by serializing
Errorobjects. We don't include digest in this case since we don't callonErrorand it's not really expected that you'd log it on the server with some way to look it up.In general this is not super useful outside throws. Especially since we hide their values in prod. However, there is one case where it is quite useful. When you replay console logs in DEV you might often log an Error object within the scope of a Server Component. E.g. the default RSC error handling just console.error and error object.
Before this would just be an empty object due to our lax console log serialization:
After:
TODO for a follow up: Flight Reply direction. This direction doesn't actually serialize thrown errors because they always reject the serialization.