[DevTools] Don't call Hooks conditionally #34644
Merged
+50
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-29-_devtools_don_t_call_hooks_conditionally
branch
from
1201ff7 to
9655a06
Compare
eps1lon
commented
Sep 29, 2025
| const min = 0; | ||
| const max = timeline.length > 0 ? timeline.length - 1 : 0; | ||
|
|
||
| if (rootID === null) { |
There was a problem hiding this comment.
These early returns will probably go away. This fixes the crashes in the meantime.
hoxyq
approved these changes
Sep 29, 2025
eps1lon
deleted the
sebbie/09-29-_devtools_don_t_call_hooks_conditionally
branch
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.