Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Using null as a rangeBehavior value is deprecated" when using "ignore" #1337

Closed
miracle2k opened this issue Aug 13, 2016 · 1 comment · May be fixed by X-oss-byte/next.js#1421
Closed

"Using null as a rangeBehavior value is deprecated" when using "ignore" #1337

miracle2k opened this issue Aug 13, 2016 · 1 comment · May be fixed by X-oss-byte/next.js#1421

Comments

@miracle2k
Copy link

I implement rangeBehaviours as a function and return "ignore". Relay shows me this warning:

Usingnullas a rangeBehavior value is deprecated. Useignoreto avoid refetching a range.
Callsite:

if (!rangeBehavior || rangeBehavior === IGNORE) {

Is the condition there wrong? I'm thinking it might need to be (!rangeBehavior && rangeBehavior !== IGNORE)

@xuorig
Copy link
Contributor

xuorig commented Aug 13, 2016

Oops, good find @miracle2k. The condition was shared because we also want to early return when it's IGNORE so (!rangeBehavior && rangeBehavior !== IGNORE) would probably not be what we want here.

PR coming for this!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants