Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay-compiler --validate option no longer available #3738

Closed
Tracked by #3749
jcolakk opened this issue Jan 11, 2022 · 5 comments
Closed
Tracked by #3749

relay-compiler --validate option no longer available #3738

jcolakk opened this issue Jan 11, 2022 · 5 comments
Labels
help wanted rust Related to the compiler written in Rust

Comments

@jcolakk
Copy link

jcolakk commented Jan 11, 2022

Hi 👋 we used to run relay-compiler --validate in our CI, but its no longer available in v13. What should we use instead?

It was really useful for us as it would catch when we forget to run relay-compiler

@alunyov
Copy link
Contributor

alunyov commented Jan 11, 2022

Oh, I think we don't use this internally. We just look for unexpected changes in the source control.

Something like this:

git diff-index --quiet HEAD -- || echo >&2 "Unexpected Changes";

But, I think it make sense to add this --validate flag to the compiler.

@alunyov alunyov added rust Related to the compiler written in Rust help wanted labels Jan 11, 2022
@jcolakk
Copy link
Author

jcolakk commented Jan 11, 2022

That could work as well, I'll try to add something like that until --validate lands again.
Btw thanks for the fast responses on the issues 👍

@jcolakk
Copy link
Author

jcolakk commented Jan 12, 2022

Btw is there any estimate when this could land?

@alunyov
Copy link
Contributor

alunyov commented Jan 12, 2022

I don't think we have an estimate, we mostly focus on "bad" issues: incorrect output, invalid configs, something that completely prevents people from using the new version. The --validate is almost a "new" feature for the V13, but I agree that this is a regression compared to the JS version.

Also, as a wise man said: "Be the change you want to see in the world.".

@jcolakk
Copy link
Author

jcolakk commented Jan 13, 2022

Of course, completely agree. I was just wondering if there is some kind of roadmap where this would be included. Understandably, its not a high prio.

Also, as a wise man said: "Be the change you want to see in the world.".

I need some courage to dive into rust but I might try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted rust Related to the compiler written in Rust
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants