Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in the cmake files. #12237

Closed
wangzhen11aaa opened this issue Jan 14, 2024 · 0 comments
Closed

Potential bug in the cmake files. #12237

wangzhen11aaa opened this issue Jan 14, 2024 · 0 comments
Labels

Comments

@wangzhen11aaa
Copy link

wangzhen11aaa commented Jan 14, 2024

Description: Some variables are not matched in cmake files.
e.g:

  1. FindNUMA.cmake: line 19-21 marked_as_advanced(NUMA_LIBRARIES, NUMA_INCLUDE_DIRS), while in the CMakeLists.txt. line 374, use include_directories(${NUMA_INCLUDE_DIR}). which is not correct.
  2. Findzstd.cmake line 21, CMakeLists.txt line 169.

Although cmake will correctly load the header in the default search path, but it makes people confused.

Expected behavior

CMakeLists.txt: line 374
include_directories(${NUMA_INCLUDE_DIRS})

Actual behavior

include_directories(${NUMA_INCLUDE_DIR})

Steps to reproduce the behavior

@ajkr ajkr added bug Confirmed RocksDB bugs up-for-grabs Up for grabs question and removed bug Confirmed RocksDB bugs labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants