Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted option file can cause the rocksdb to crash #13102

Open
NoamRabi20 opened this issue Oct 30, 2024 · 0 comments
Open

Corrupted option file can cause the rocksdb to crash #13102

NoamRabi20 opened this issue Oct 30, 2024 · 0 comments
Assignees

Comments

@NoamRabi20
Copy link

When the option file contain characters which are not asci (asci value >127) the "isspace" check will cause to crash

Expected behavior

We should cast all input characters to be unsigned char.

Actual behavior

isspace method (as part of TrimAndRemoveComment) will cause the process to crash.

Steps to reproduce the behavior

fill the option file with characters that their ascii value is more than 127.

@jowlyzhang jowlyzhang self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants