-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use OutputValidator
in SstFileWriter
#7599
Comments
We should bump this issue up so that it's not buried in the bottom :) |
Guys, I'm taking this up as my ramp up task into the project :) |
Sorry I have not checked the google group. Let me try to catch up on the current PR and see if I can help sometime this coming week. This issue or the PR are probably the best forums although the unblocking time can still be slow as you found.. :/ |
@ajkr The code is here - main...briantkim93:add_outputvalidator_to_sstfilewrites sst_file_writer.cc lines 375-401. |
Very sorry for the delay. It takes a while for anything to reach the front of my queue. SstFileReader is one way to read back data written by an SstFileWriter. But it is a user API and therefore returns user keys, which exclude internal metadata (seqno+value type). Meanwhile,
We had a slack channel but - at least for me - the difficulty was more about context switching than communication medium. That channel is gone now and I slightly prefer keeping code discussion centralized on GitHub. |
Hey man, thanks a lot for your help. I raised the PR here. |
#7134 and #7467 add kv checksum and key order verification to files as they're created via
OutputValidator
. The verifications currently apply to files generated by flush and compaction. It'd be good to introduce these checks forSstFileWriter
-generated files as well.The text was updated successfully, but these errors were encountered: