Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring rdb to python3 and add it to CI-build or move it to a separate repo or deprecate it #9382

Closed
riversand963 opened this issue Jan 12, 2022 · 0 comments
Labels
Build build, makefile, cmake, scripts rocksdb-7.0 PRs with breaking API changes that need to land in the next major release, 7.0.

Comments

@riversand963
Copy link
Contributor

riversand963 commented Jan 12, 2022

According to https://github.com/facebook/rocksdb/tree/main/tools/rdb#readme, rdb relies on Python2 for which support is no longer provided, even for security issues (https://www.python.org/doc/sunset-python-2/).

Currently, the tools/rdb is not compiled during daily development, making it easy to break. If the decision is to keep rdb in rocksdb main repo, we should include it in at least one CI build.

Two other options:

  • Move it to a "plugin" repo outside the main repo
  • Deprecate it

Looks like it is broken already because I don't think the following will compile: https://github.com/facebook/rocksdb/blob/main/tools/rdb/db_wrapper.cc#L8

// in rdb.cc and db_wrapper.cc
#include "db/_wrapper.h"
@riversand963 riversand963 added up-for-grabs Up for grabs Build build, makefile, cmake, scripts labels Jan 12, 2022
@riversand963 riversand963 added the rocksdb-7.0 PRs with breaking API changes that need to land in the next major release, 7.0. label Jan 15, 2022
@riversand963 riversand963 removed the up-for-grabs Up for grabs label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build build, makefile, cmake, scripts rocksdb-7.0 PRs with breaking API changes that need to land in the next major release, 7.0.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant