Remove useless into_iter() calls

Summary:
In Rust 1.68.0, the `useless_conversion` clippy lint [got smarter](rust-lang/rust-clippy#10020).
Fix all instances of that lint in Mononoke.

Reviewed By: markbt

Differential Revision: D44378069

fbshipit-source-id: acfd6c77c6a400830c378b4040661323e7232441

Author: Pierre Chevalier

eden/mononoke/blobrepo/blobrepo_hg/src/create_changeset.rs

@@ -333,7 +333,7 @@ impl CreateChangeset {
                 // update changeset mapping
                 let completion_record = ChangesetInsert {
                     cs_id: bonsai_cs.get_changeset_id(),
-                    parents: bonsai_cs.parents().into_iter().collect(),
+                    parents: bonsai_cs.parents().collect(),
                 };
                 complete_changesets
                     .add(&ctx, completion_record)

eden/mononoke/blobstore/sqlblob/src/lib.rs

@@ -243,10 +243,7 @@ impl Sqlblob {
 
         let config_handle = get_gc_config_handle(config_store)?;
 
-        let futs: FuturesOrdered<_> = (0..shard_count)
-            .into_iter()
-            .map(connection_factory)
-            .collect();
+        let futs: FuturesOrdered<_> = (0..shard_count).map(connection_factory).collect();
 
         let shard_connections = futs.try_collect::<Vec<_>>().await?;
         let mut write_connections = Vec::with_capacity(shard_count);

eden/mononoke/blobstore/virtually_sharded_blobstore/src/shard.rs

@@ -52,10 +52,7 @@ pub struct Shards {
 
 impl Shards {
     pub fn new(shard_count: NonZeroUsize, perf_counter_type: PerfCounterType) -> Self {
-        let semaphores = (0..shard_count.get())
-            .into_iter()
-            .map(|_| Semaphore::new(1))
-            .collect();
+        let semaphores = (0..shard_count.get()).map(|_| Semaphore::new(1)).collect();
 
         Self {
             semaphores,

eden/mononoke/changesets/changesets_creation/src/lib.rs

@@ -84,7 +84,7 @@ pub async fn save_changesets(
             let bcs_id = bcs.get_changeset_id();
             let completion_record = ChangesetInsert {
                 cs_id: bcs_id,
-                parents: bcs.parents().into_iter().collect(),
+                parents: bcs.parents().collect(),
             };
             bonsai_complete_futs.push(complete_changesets.add(ctx, completion_record));
         }

eden/mononoke/cmds/blobstore_healer/wal_healer/mod.rs

@@ -182,7 +182,6 @@ impl WalHealer {
         let unique_blobstore_keys = queue_entries
             .iter()
             .unique_by(|entry| entry.blobstore_key.clone())
-            .into_iter()
             .count();
 
         let healing_futures: Vec<(_, u64)> = queue_entries

eden/mononoke/cmds/rechunker.rs

@@ -64,7 +64,6 @@ fn main(fb: FacebookInit) -> Result<(), Error> {
     let filenode_ids: Vec<_> = matches
         .values_of("filenodes")
         .unwrap()
-        .into_iter()
         .map(|f| {
             HgNodeHash::from_str(f)
                 .map(HgFileNodeId::new)

eden/mononoke/hooks/src/rust_hooks/limit_commit_message_length.rs

@@ -94,7 +94,7 @@ fn extract_title<'a>(message: &'a str, max_length: usize) -> &'a str {
         message
     };
 
-    message.split('\n').into_iter().next().unwrap_or("")
+    message.split('\n').next().unwrap_or("")
 }
 
 #[cfg(test)]

eden/mononoke/megarepo_api/commit_transformation/src/lib.rs

@@ -132,7 +132,6 @@ pub fn create_directory_source_to_target_multi_mover(
                 let override_prefix_src = MPath::new(override_prefix_src.clone())?;
                 if override_prefix_src.is_prefix_of(mpath_element_iter(path)) {
                     let suffix: Vec<_> = mpath_element_iter(path)
-                        .into_iter()
                         .skip(override_prefix_src.num_components())
                         .collect();
 

eden/mononoke/mononoke_api/src/test/test_repo.rs

@@ -872,7 +872,6 @@ async fn tree_list(fb: FacebookInit) -> Result<(), Error> {
             let tree = path.tree().await?.unwrap();
             tree.list()
                 .await?
-                .into_iter()
                 .map(|(name, _entry)| name)
                 .collect::<Vec<_>>()
         },
@@ -889,7 +888,6 @@ async fn tree_list(fb: FacebookInit) -> Result<(), Error> {
             let tree = path.tree().await?.unwrap();
             tree.list()
                 .await?
-                .into_iter()
                 .map(|(name, _entry)| name)
                 .collect::<Vec<_>>()
         },
@@ -907,7 +905,6 @@ async fn tree_list(fb: FacebookInit) -> Result<(), Error> {
             {
                 tree.list()
                     .await?
-                    .into_iter()
                     .map(|(name, _entry)| name)
                     .collect::<Vec<_>>()
             },
@@ -920,7 +917,6 @@ async fn tree_list(fb: FacebookInit) -> Result<(), Error> {
         match tree
             .list()
             .await?
-            .into_iter()
             .collect::<HashMap<_, _>>()
             .get("subsubdir2")
             .expect("entry should exist for subsubdir2")
@@ -935,7 +931,6 @@ async fn tree_list(fb: FacebookInit) -> Result<(), Error> {
             let tree = path.tree().await?.unwrap();
             tree.list()
                 .await?
-                .into_iter()
                 .map(|(name, entry)| match entry {
                     TreeEntry::File(file) => {
                         Some((name, file.size(), file.content_sha1().to_string()))
@@ -956,7 +951,6 @@ async fn tree_list(fb: FacebookInit) -> Result<(), Error> {
             let tree = repo.tree(subsubdir2_id).await?.expect("tree exists");
             tree.list()
                 .await?
-                .into_iter()
                 .map(|(name, _entry)| name)
                 .collect::<Vec<_>>()
         },

eden/mononoke/newfilenodes/src/shards.rs

@@ -34,12 +34,10 @@ pub struct Shards {
 impl Shards {
     pub fn new(filenodes_concurrency: usize, history_concurrency: usize) -> Self {
         let filenodes = (0..filenodes_concurrency)
-            .into_iter()
             .map(|_| Semaphore::new(1))
             .collect();
 
         let history = (0..history_concurrency)
-            .into_iter()
             .map(|_| Semaphore::new(1))
             .collect();
 

eden/mononoke/newfilenodes/src/test/test_reader.rs

@@ -980,7 +980,6 @@ fn create_unsharded() -> Result<Vec1<Connection>, Error> {
 
 fn create_sharded() -> Result<Vec1<Connection>, Error> {
     Ok((0..16)
-        .into_iter()
         .map(|_| build_shard())
         .collect::<Result<Vec<_>, Error>>()?
         .try_into()?)

eden/mononoke/scs_server/src/methods/repo.rs

@@ -758,7 +758,6 @@ impl SourceControlServiceImpl {
         )
         .await?;
         let cs_ids = std::iter::zip(params.commits, changesets)
-            .into_iter()
             .map(|(commit, cs)| {
                 cs.map(|cs| cs.id())
                     .ok_or_else(|| errors::commit_not_found(commit.to_string()))

eden/mononoke/tools/admin/src/commands/commit/split.rs

@@ -286,20 +286,11 @@ mod test {
 
             let bcs = split[0].load(&ctx, repo.repo_blobstore()).await?;
             let parents: Vec<ChangesetId> = vec![];
-            assert_eq!(
-                parents,
-                bcs.parents().into_iter().collect::<Vec<ChangesetId>>()
-            );
+            assert_eq!(parents, bcs.parents().collect::<Vec<ChangesetId>>());
             let bcs = split[1].load(&ctx, repo.repo_blobstore()).await?;
-            assert_eq!(
-                vec![split[0]],
-                bcs.parents().into_iter().collect::<Vec<_>>()
-            );
+            assert_eq!(vec![split[0]], bcs.parents().collect::<Vec<_>>());
             let bcs = split[2].load(&ctx, repo.repo_blobstore()).await?;
-            assert_eq!(
-                vec![split[1]],
-                bcs.parents().into_iter().collect::<Vec<_>>()
-            );
+            assert_eq!(vec![split[1]], bcs.parents().collect::<Vec<_>>());
         }
 
         // Now split by file size