New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add the associated type to the `Air` trait for `LogUpGkrEvaluator`. #318

Open

Al-Kindi-0 opened this issue Sep 17, 2024 · 0 comments

Contributor

Al-Kindi-0 commented Sep 17, 2024 •

edited by irakliyk

Loading

Not for this PR: I think the only reason why we need to pass the evaluator here (instead of getting it from self.logup_gkr_constraints_evaluator) is that the evaluator does not have a concrete type, and thus, cannot be a field inside a struct. If so, we may want to re-add the associated type to the Air trait for LogUpGkrEvaluator. But this would be for a follow-up PR.

Originally posted by @irakliyk in #317 (comment)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment